Skip to content

Conversation

@gzh-terry
Copy link
Contributor

@gzh-terry gzh-terry commented Dec 29, 2025

No description provided.

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bug: v/82379

A initial version that starts compiling the files.

Signed-off-by: Zihao Gao <[email protected]>
bug: v/82379

Init and uninit for PA sync.

Signed-off-by: Zihao Gao <[email protected]>
bug: v/82379

Periodic advertising often comes from extended scanning, so we add an parser here.
An alternative is Periodic Advertising Sync Transfer (to be implemented later).

Signed-off-by: Zihao Gao <[email protected]>
bug: v/82380

Initial version of Auracast sink test tool

Signed-off-by: Zihao Gao <[email protected]>
bug: v/82380

Add scan command to search active Auracast sources.

Signed-off-by: Zihao Gao <[email protected]>
bug: v/82379

Parse the scan result at the client side, so we can reduce the uplink data.

Signed-off-by: Zihao Gao <[email protected]>
bug: v/82275

Add TxPower, Periodic Advertising Interval, and correct the conversion of adv_type.

Signed-off-by: Zihao Gao <[email protected]>
bug: v/82379

Parse scan result at bttol to check if there is an Auracast source available.

Signed-off-by: Zihao Gao <[email protected]>
bug: v/82379

Skip logs that are not available.
Add more debug logs on error.

Signed-off-by: Zihao Gao <[email protected]>
bug: v/82379

Allow to stop scanning for periodic advertisers.

Signed-off-by: Zihao Gao <[email protected]>
bug: v/82820

Add an extra flag to indicate whether periodic advertising is present in the scan result.

Signed-off-by: Zihao Gao <[email protected]>
bug: v/82820

Modify message codes so its safe when client and server have different version of codes.

Signed-off-by: Zihao Gao <[email protected]>
Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

* @brief LE Periodic Advertising Terminate Sync command.
*
* This command is used to stop reception of the periodic advertising train identified by the
* `handle`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean "by the handle", where is the handle definition?

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

return;

status = bt_pa_sync_parse_adv_data(info, result);
if (status != BT_STATUS_SUCCESS)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Free the info when return error?

static int scan_cmd(void* handle, int argc, char* argv[]);

static bttool_auracast_sink_t* g_auracast_sink = NULL;
static bt_command_t g_auracast_sink_tables[] = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add const for the table?

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

scan_on_result_data_update(&result_info, ad->data);
}

static struct bt_le_scan_cb scan_cbs = {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add const for the callback struct?

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@huangyulong3 huangyulong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants