-
Notifications
You must be signed in to change notification settings - Fork 32
Add PA sync service #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add PA sync service #352
Conversation
63d8e82 to
d11efce
Compare
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bug: v/82379 A initial version that starts compiling the files. Signed-off-by: Zihao Gao <[email protected]>
bug: v/82379 Init and uninit for PA sync. Signed-off-by: Zihao Gao <[email protected]>
bug: v/82379 Periodic advertising often comes from extended scanning, so we add an parser here. An alternative is Periodic Advertising Sync Transfer (to be implemented later). Signed-off-by: Zihao Gao <[email protected]>
bug: v/82380 Initial version of Auracast sink test tool Signed-off-by: Zihao Gao <[email protected]>
bug: v/82380 Add scan command to search active Auracast sources. Signed-off-by: Zihao Gao <[email protected]>
bug: v/82379 Parse the scan result at the client side, so we can reduce the uplink data. Signed-off-by: Zihao Gao <[email protected]>
bug: v/82275 Add TxPower, Periodic Advertising Interval, and correct the conversion of adv_type. Signed-off-by: Zihao Gao <[email protected]>
bug: v/82379 Parse scan result at bttol to check if there is an Auracast source available. Signed-off-by: Zihao Gao <[email protected]>
bug: v/82379 Skip logs that are not available. Add more debug logs on error. Signed-off-by: Zihao Gao <[email protected]>
bug: v/82379 Allow to stop scanning for periodic advertisers. Signed-off-by: Zihao Gao <[email protected]>
bug: v/82820 Add an extra flag to indicate whether periodic advertising is present in the scan result. Signed-off-by: Zihao Gao <[email protected]>
bug: v/82820 Modify message codes so its safe when client and server have different version of codes. Signed-off-by: Zihao Gao <[email protected]>
d7c9c60
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
| * @brief LE Periodic Advertising Terminate Sync command. | ||
| * | ||
| * This command is used to stop reception of the periodic advertising train identified by the | ||
| * `handle`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean "by the handle", where is the handle definition?
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
| return; | ||
|
|
||
| status = bt_pa_sync_parse_adv_data(info, result); | ||
| if (status != BT_STATUS_SUCCESS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Free the info when return error?
| static int scan_cmd(void* handle, int argc, char* argv[]); | ||
|
|
||
| static bttool_auracast_sink_t* g_auracast_sink = NULL; | ||
| static bt_command_t g_auracast_sink_tables[] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add const for the table?
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
| scan_on_result_data_update(&result_info, ad->data); | ||
| } | ||
|
|
||
| static struct bt_le_scan_cb scan_cbs = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add const for the callback struct?
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
huangyulong3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No description provided.